Add example for exec with tty enabled.#515
Add example for exec with tty enabled.#515xychu wants to merge 1 commit intokubernetes-client:masterfrom
tty enabled.#515Conversation
Including resize pty via `RESIZE_CHANNEL`.
| # This example used code(the `Interceptor` related part) from | ||
| # http://sqizit.bartletts.id.au/2011/02/14/pseudo-terminals-in-python/ | ||
| # which is licensed under the MIT license: | ||
| # Copyright (c) 2011 Joshua D. Bartlett |
There was a problem hiding this comment.
Sorry that I couldn't get to this earlier. I'm concerned with the MIT licensing and worried if having another license violates our CLA. Did a quick search in our code base and I didn't see any source code under MIT license in client-python and kubernetes/kubernetes (third party vendors don't apply).
@yliaog @mbohlool Do we have existing best-practice / SIG in community that we can consult with?
I'd be happy to review & merge this PR after we sort out the license question.
There was a problem hiding this comment.
https://www.cncf.io/blog/2017/02/01/cncf-recommends-aslv2/
CNCF recommends Apache License. Not sure if MIT License is ok though.
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
the
cncf-cla: yes
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
the
lifecycle/stale
|
/close |
|
@xychu: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
Including resize pty via
RESIZE_CHANNEL.